Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config scopes #351

Merged
merged 6 commits into from
Jan 11, 2023
Merged

Fix config scopes #351

merged 6 commits into from
Jan 11, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Dec 23, 2022

Description:

  • I fixed a few issues with config scopes and expirable modules. Modules don't need AzimuthConfig as a scope if they are affected by smart tags, as long as they are ExpirableModules. Since FilterableModules are already ExpirableModules, they were all ok except MetricsbyFilter.
  • I also separated the metrics from the ModelContractConfig, to avoid recomputing all predictions if we only change the metrics.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma
Copy link
Contributor Author

gabegma commented Dec 23, 2022

When you have a chance, could you take a look and make sure that this makes sense to you @Dref360, our caching expert?

@gabegma gabegma marked this pull request as ready for review December 23, 2022 23:06
Copy link
Contributor

@Dref360 Dref360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one naming comment, and that's it! Good job! 👍

@gabegma gabegma enabled auto-merge (squash) January 11, 2023 15:47
@gabegma gabegma merged commit 0f903d1 into main Jan 11, 2023
@gabegma gabegma deleted the ggm/fix-config-scope branch January 11, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants