Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @xmldom/xmldom #356

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Update @xmldom/xmldom #356

merged 1 commit into from
Jan 5, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Dec 29, 2022

Resolve #

Description:

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 29, 2022
@gabegma gabegma marked this pull request as ready for review December 30, 2022 19:13
@gabegma gabegma merged commit 1a15833 into main Jan 5, 2023
@gabegma gabegma deleted the pr/ggm/update-xmldom branch January 5, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants