Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a message while config is updated #412

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

nandhinibsn
Copy link
Contributor

@nandhinibsn nandhinibsn commented Jan 31, 2023

Resolve #

Description:

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@nandhinibsn
Copy link
Contributor Author

I added a section to display a message with circular progress while the config is getting updated. Please let me know what do you think about the approach and design
image

Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of two independant conditions, repeating isUpdatingConfig, I find using a ternary operator would be clearer and more robust. Here are the two changes necessary:

webapp/src/pages/Settings.tsx Outdated Show resolved Hide resolved
webapp/src/pages/Settings.tsx Outdated Show resolved Hide resolved
@nandhinibsn
Copy link
Contributor Author

Thank you for reviewing it @JosephMarinier

@nandhinibsn nandhinibsn merged commit 2a005ed into main Jan 31, 2023
@nandhinibsn nandhinibsn deleted the nandhini/add-patch-update-message branch January 31, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants