Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor add_tags method #423

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Refactor add_tags method #423

merged 1 commit into from
Feb 8, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Feb 6, 2023

Part of #297

Description:

  • Refactor add_tags method so it is cleaner. it seems some code was redundant and that we were saving prediction tags in the base dataset split.
  • This triggered many mypy errors so I needed to refactor further the types related to tags.
  • This is preliminary work before importing proposed actions.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma marked this pull request as ready for review February 7, 2023 20:43
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! 😲 Good job! 👌 Thank you for cleaning that up.

@gabegma gabegma merged commit f6ca140 into main Feb 8, 2023
@gabegma gabegma deleted the ggm/refactor-add-tags branch February 8, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants