Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump isort in pre-commit #458

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Bump isort in pre-commit #458

merged 1 commit into from
Feb 21, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Feb 20, 2023

Description:

  • As I was playing with pre-commit, I no longer could run the previous version of isort. Can you verify that this new version works for you too when you launch pre-commit run --all-files?

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@@ -52,7 +52,7 @@ repos:
entry: poetry run flake8
types: [ python ]
- repo: https://github.com/pycqa/isort
rev: 5.8.0
rev: 5.12.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify that this new version works for you too when you launch pre-commit run --all-files?

It seems to for me, although it seems to work on main too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not for me anymore. Thanks!

@gabegma gabegma merged commit 3aef10e into main Feb 21, 2023
@gabegma gabegma deleted the ggm/bump-isort branch February 21, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants