Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link from confusion matrix to utterance table #470

Merged

Conversation

JosephMarinier
Copy link
Contributor

@JosephMarinier JosephMarinier commented Feb 28, 2023

Resolve #469

Description:

That was very easy. To be honest, GitHub Copilot (Codex) almost got it on its own. 😅 Here (suggestion in gray), it figured out that the label and prediction filters should be the class names, and which of the rowIndex and the columnIndex represents the label and the prediction:
Screen Shot 2023-02-27 at 7 57 52 PM
It was only missing wrapping the prediction in an array (expecting string[] and not string). After I added it and I hit enter, GitHub Colipot suggested the label correctly, with the added array:
Screen Shot 2023-02-27 at 8 31 48 PM
My mind is blown. 🤯

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@JosephMarinier JosephMarinier changed the title Link from confusion matrix cells to utterance table Link from confusion matrix to utterance table Feb 28, 2023
@gabegma
Copy link
Contributor

gabegma commented Feb 28, 2023

Wow, so cool!! I'm not able to make the row/column work I think.

@JosephMarinier JosephMarinier merged commit cb67a25 into main Mar 1, 2023
@JosephMarinier JosephMarinier deleted the joseph/link-from-confusion-matrix-to-utterances branch March 1, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the confusion matrix as a filter
3 participants