Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix negative query params #471

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Fix negative query params #471

merged 3 commits into from
Mar 2, 2023

Conversation

JosephMarinier
Copy link
Contributor

@JosephMarinier JosephMarinier commented Mar 1, 2023 •
edited
Loading

Description:

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@JosephMarinier JosephMarinier self-assigned this Mar 1, 2023
@JosephMarinier JosephMarinier marked this pull request as ready for review March 1, 2023 20:40
gabegma
gabegma approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you tell me how this is useful for the front end? Does it change the type?

@JosephMarinier
Copy link
Contributor Author

Can you tell me how this is useful for the front end? Does it change the type?

No, it does not impact the front end. I was already checking for negative pipeline_index in the front end. This only impacts the API and the Swagger UI.

@JosephMarinier JosephMarinier merged commit 7db0825 into main Mar 2, 2023
@JosephMarinier JosephMarinier deleted the joseph/fix-negative-query-params branch March 2, 2023 16:48
JosephMarinier added a commit that referenced this pull request Mar 6, 2023
@JosephMarinier
Merge commit '674585e9bdfd543771ee74b407059b41fc979f24' into joseph/l…
633379e 
…oad-config-history

* commit '674585e9bdfd543771ee74b407059b41fc979f24':
  Clean up docker image (#316)
  Validate config min/max values (#474)
  Bump werkzeug from 2.1.0 to 2.2.3 (#443)
  Bump dns-packet from 5.3.1 to 5.4.0 in /webapp (#473)
  Update tensorflow (#355)
  Bump json5 from 1.0.1 to 1.0.2 in /webapp (#359)
  Fix negative query params (#471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabegma gabegma gabegma approved these changes

Assignees

@JosephMarinier JosephMarinier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JosephMarinier @gabegma