Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config modal #487

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Improve config modal #487

merged 3 commits into from
Mar 22, 2023

Conversation

JosephMarinier
Copy link
Contributor

@JosephMarinier JosephMarinier commented Mar 13, 2023

Description:

  • Put loading and error states inside the Dialog box
    • Before, if there was an error, you would not be able to close de Dialog box, since the Xbutton wouldn't show up.
    • ⚠️ The diff in Settings.tsx seems overwhelming, but the code is just moving around, with no real changes.
  • Render PageHeader in only one place (as opposed to once in BasicLayout and once in Exploration) so that the config modal stays in place if we use the browser back and forward buttons, to avoid losing unsaved changes in the config.
    • ⚠️ The diff in Exploration.tsx seems overwhelming, but it's just the indentation, with no real changes.
  • Resolve warning
    • ⚠️ Not related to the config.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

Copy link
Contributor

@nandhinibsn nandhinibsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me. 👍

(as opposed to once in `BasicLayout` and once in `Exploration`) so that the config modal stays in place if we use the browser back and forward buttons, to avoid losing unsaved changes in the config.
@JosephMarinier JosephMarinier merged commit ee9081a into main Mar 22, 2023
@JosephMarinier JosephMarinier deleted the joseph/single-page-header branch March 22, 2023 17:36
@JosephMarinier JosephMarinier mentioned this pull request Apr 12, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants