Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumbs #541

Merged

Conversation

JosephMarinier
Copy link
Contributor

@JosephMarinier JosephMarinier commented Apr 12, 2023

Description:

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@JosephMarinier JosephMarinier changed the base branch from main to joseph/fix-config-closing-on-error April 12, 2023 18:24
Comment on lines -37 to -39
utteranceId,
datasetSplitName,
mainView = "utterances",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explaining the bug: since I moved PageHeader in #487, those were always undefined. My new approach here doesn't need those, since it uses regular expressions to match the location.pathname.

@JosephMarinier JosephMarinier merged commit 8c5c499 into joseph/fix-config-closing-on-error Apr 12, 2023
@JosephMarinier JosephMarinier deleted the joseph/fix-breadcrumbs branch April 12, 2023 21:44
gabegma pushed a commit that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants