Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add common fields configuration section and persistentId under the project section #505

Merged
merged 14 commits into from
Mar 25, 2023
Merged

Add common fields configuration section and persistentId under the project section #505

merged 14 commits into from
Mar 25, 2023

Conversation

nandhinibsn
Copy link
Contributor

@nandhinibsn nandhinibsn commented Mar 21, 2023 •
edited
Loading

Resolve #

Description:

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@nandhinibsn nandhinibsn self-assigned this Mar 21, 2023
@JosephMarinier
Copy link
Contributor

Did you mean to make a PR against nandhini/config_ui_string_editable instead of main?

@nandhinibsn nandhinibsn changed the base branch from main to nandhini/config_ui_string_editable March 22, 2023 15:55
@nandhinibsn nandhinibsn force-pushed the nandhini/config_ui_string_editable branch from 720b8aa to d16611e Compare March 23, 2023 16:44
JosephMarinier
JosephMarinier reviewed Mar 24, 2023
View reviewed changes
webapp/src/pages/Settings.tsx Outdated
},
})
: setPartialConfig({
...partialConfig,
[field]: newValue,
[field]: isNull(newValue),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch out! Most fields can't be null. Only rejection_class, saliency_layer, and remote can be null.

Base automatically changed from nandhini/config_ui_string_editable to main March 24, 2023 15:20
@nandhinibsn nandhinibsn mentioned this pull request Mar 24, 2023
Merged
4 tasks
nandhinibsn and others added 11 commits March 24, 2023 15:53
@nandhinibsn nandhinibsn force-pushed the nandhini/add-config-common-fields branch from 7cef7c6 to bba2de0 Compare March 24, 2023 20:34
@JosephMarinier JosephMarinier enabled auto-merge (squash) March 25, 2023 11:21
@JosephMarinier JosephMarinier enabled auto-merge (squash) March 25, 2023 11:22
@JosephMarinier JosephMarinier merged commit d530ae5 into main Mar 25, 2023
@JosephMarinier JosephMarinier deleted the nandhini/add-config-common-fields branch March 25, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabegma gabegma gabegma left review comments

@JosephMarinier JosephMarinier JosephMarinier approved these changes

Assignees

@nandhinibsn nandhinibsn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nandhinibsn @JosephMarinier @gabegma