Fix overwriting the partial config on changing the language field #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -251,6 +251,7 @@ const Settings: React.FC<Props> = ({ open, onClose }) => { | |||
| React.useEffect(() => { | |||
| if (defaultConfig && defaultConfig.language !== resultingConfig.language) { | |||
| setPartialConfig({ | |||
| ...partialConfig, | |||
There was a problem hiding this comment.
We forgot to add partialConfig to the dependency array of React.useEffect. Can you make a quick commit with that?
src/pages/Settings.tsx
Line 285:6: React Hook React.useEffect has a missing dependency: 'partialConfig'. Either include it or remove the dependency array. You can also do a functional update 'setPartialConfig(p => ...)' if you only need 'partialConfig' in the 'setPartialConfig' call react-hooks/exhaustive-deps
There was a problem hiding this comment.
Sorry for missing this. Sure, I can add it to this PR
There was a problem hiding this comment.
Perfect, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #
Description:
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-filesat the end.our users.
READMEfiles and our wiki for any big design decisions, if relevant.