Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to comments and logs #533

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Minor fixes to comments and logs #533

merged 3 commits into from
Apr 4, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Apr 4, 2023 •
edited
Loading

Description:

  • A few things that I saw while refactoring the repo:
    • Make some comments shorter so they fit on a line.
    • Add/modify some logs for helpfulness.
    • Add missing TODO.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma changed the title Ggm/add logging Minor fixes to comments and logs Apr 4, 2023
@gabegma gabegma self-assigned this Apr 4, 2023
lindsaydbrin
lindsaydbrin approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@lindsaydbrin lindsaydbrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM!

@gabegma @lindsaydbrin
Update azimuth/utils/ml/perturbation_test.py
bec31cc 
Co-authored-by: Lindsay Brin <lindsay.brin@servicenow.com>
@gabegma gabegma enabled auto-merge (squash) April 4, 2023 18:13
@gabegma gabegma merged commit 63311d4 into main Apr 4, 2023
@gabegma gabegma deleted the ggm/add-logging branch April 4, 2023 18:36
gabegma added a commit that referenced this pull request Apr 19, 2023
@gabegma @lindsaydbrin
Minor fixes to comments and logs (#533)
c76d6f5 
* Add and modify some logging

* Cleanup comments and logs

* Update azimuth/utils/ml/perturbation_test.py

Co-authored-by: Lindsay Brin <lindsay.brin@servicenow.com>

---------

Co-authored-by: Lindsay Brin <lindsay.brin@servicenow.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindsaydbrin lindsaydbrin lindsaydbrin approved these changes

Assignees

@gabegma gabegma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabegma @lindsaydbrin