Fix DeleteById with RowVersion for SQL Server

ServiceStack · Jul 24, 2018 · af3a2cd · af3a2cd
1 parent 76b0ced
commit af3a2cd
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/src/ServiceStack.OrmLite.SqlServer/Converters/SqlServerSpecialConverters.cs b/src/ServiceStack.OrmLite.SqlServer/Converters/SqlServerSpecialConverters.cs
@@ -4,9 +4,6 @@ namespace ServiceStack.OrmLite.SqlServer.Converters
 {
     public class SqlServerRowVersionConverter : RowVersionConverter
     {
-        public override string ColumnDefinition
-        {
-            get { return "rowversion"; }
-        }
+        public override string ColumnDefinition => "rowversion";
     }
 }
diff --git a/src/ServiceStack.OrmLite/OrmLiteWriteCommandExtensions.cs b/src/ServiceStack.OrmLite/OrmLiteWriteCommandExtensions.cs
@@ -573,6 +573,9 @@ internal static string DeleteByIdSql<T>(this IDbCommand dbCmd, object id, ulong
 
             var rowVersionParam = dbCmd.CreateParameter();
             rowVersionParam.ParameterName = dialectProvider.GetParam("rowVersion");
+            var converter = dialectProvider.GetConverterBestMatch(typeof(ulong));
+            converter.InitDbParam(rowVersionParam, typeof(ulong));
+
             rowVersionParam.Value = rowVersion;
             dbCmd.Parameters.Add(rowVersionParam);
 

diff --git a/tests/ServiceStack.OrmLite.Tests/RowVersionTests.cs b/tests/ServiceStack.OrmLite.Tests/RowVersionTests.cs
@@ -360,6 +360,18 @@ public void Can_delete_with_current_rowversion()
             var count = db.Count<ModelWithRowVersion>(m => m.Id == rowId);
             Assert.That(count, Is.EqualTo(0));
         }
+
+        [Test]
+        public void Can_DeleteById_with_current_rowversion()
+        {
+            var rowId = db.Insert(new ModelWithRowVersion { Text = "Four" }, selectIdentity: true);
+            var row = db.SingleById<ModelWithRowVersion>(rowId);
+
+            db.DeleteById<ModelWithRowVersion>(row.Id, rowVersion:row.RowVersion);
+
+            var count = db.Count<ModelWithRowVersion>(m => m.Id == rowId);
+            Assert.That(count, Is.EqualTo(0));
+        }
 
         [Test]
         public void Update_with_outdated_rowversion_throws()