Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varying artist length, results in songs not aligning. #41

Closed
edencorbin opened this issue May 16, 2018 · 7 comments
Closed

Varying artist length, results in songs not aligning. #41

edencorbin opened this issue May 16, 2018 · 7 comments

Comments

@edencorbin
Copy link

If you have different length artist names by song (such as featuring xyz), then all the songs go out of alignment, is this intended? I didn't see an api/option to change this.

@SevenOutman
Copy link
Owner

@edencorbin Could you provide some screenshots?

@edencorbin
Copy link
Author

alignmentissue

@edencorbin
Copy link
Author

You can see it is directly offset by the length of the artist name.... I would think some stying options like maybe left align, or perhaps tabled so that centering would still work with two different cells. Most likely I'm missing something that already can be done : ' )

@SevenOutman
Copy link
Owner

SevenOutman commented May 17, 2018

@edencorbin It's apparently not intended. And I can't reproduce it.

The screenshot below is taken on https://vue-aplayer.js.org just now, alignment works as expected.
image

You may check this link to see if it also works all right in your browser.

  • If yes, maybe you have some issue in your custom styles.
  • If not, please tell me what OS and browsers you're using.

@edencorbin
Copy link
Author

yes, it looks good on that link.

I'n not applying any custom styling to my knowledge:

<template>
  <div>
    <aplayer 
      :music="list[0]"
      :list="list"
      :repeat="'list'"
    />
  </div>
</template>

I do have purecss installed, but I just checked ensuring it is not in a purecss element, and that didn't change anything.

@edencorbin
Copy link
Author

edencorbin commented May 18, 2018

@SevenOutman wrapping it in text-align: left style fixed it..... it would seem artist auto align right, and the song names are whatever your parent element styling is? I guess that is pretty good generally, I'll close out this ticket. I didn't notice much mention of styling in the docs, would be great if that was explained a little.

@SevenOutman
Copy link
Owner

SevenOutman commented May 18, 2018

@edencorbin Glad you have solved it! Yes the alignment can be affected by parent elements. This will be improved in next minor or patch update, in which several UI improvements are included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants