Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

element verification rewrite #1466

Merged
merged 7 commits into from
Jan 24, 2024

Merge branch 'main' into 1461-enhancement-revamp-validation-error-mes…

b220204
Select commit
Loading
Failed to load commit list.
Merged

element verification rewrite #1466

Merge branch 'main' into 1461-enhancement-revamp-validation-error-mes…
b220204
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 24, 2024 in 1s

50.53% (-0.46%) compared to 74298c6

View this Pull Request on Codecov

50.53% (-0.46%) compared to 74298c6

Details

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (74298c6) 50.98% compared to head (b220204) 50.53%.
Report is 1 commits behind head on main.

Files Patch % Lines
.../shaft/validation/internal/ValidationsHelper2.java 76.31% 4 Missing and 5 partials ⚠️
...shaft/validation/internal/ValidationsExecutor.java 80.00% 4 Missing ⚠️
...n/internal/WebDriverElementValidationsBuilder.java 62.50% 3 Missing ⚠️
...m/shaft/validation/internal/ValidationsHelper.java 87.50% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1466      +/-   ##
============================================
- Coverage     50.98%   50.53%   -0.46%     
+ Complexity     1292     1282      -10     
============================================
  Files           108      109       +1     
  Lines         10069    10079      +10     
  Branches       1006     1012       +6     
============================================
- Hits           5134     5093      -41     
- Misses         4313     4357      +44     
- Partials        622      629       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov