This repository has been archived by the owner on May 9, 2023. It is now read-only.
Removed partial recovery functionality and updated the documentation #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sourcery Code Quality Report (beta)✅ Merging this PR will increase code quality in the affected files by 0.32 out of 10.
Here are some functions in these files that still need a tune-up:
We are actively working on this report - lots more documentation and extra metrics to come! |
ShahriyarR
added a commit
that referenced
this pull request
Apr 30, 2021
* Added my holly first bulk changes for issue #372 * It seems to be incremental backups are also works for issue #372 * Using sourcery.ai for eliminating wtf if statements for issue #372 * Added changes for prepare section also improved code quality for issue #372 * Fixing prepare stage pfff again for issue #372 * Added mysql sql client command builder for issue #372 * Functionalized several repeated code portions added several pfff quality code portions for issue #372 * Deprecated the deprecated workaround for PXB bug as there is no need for issue #372 * The documentation cleaning action for issue #372 * Few more improvements for issue #372 * Trying generate the code reference documentation for issue #372 * Version Bump for release version 2.0 * Added few methods for creating docker environment for issue #388 * Finalized the docker environment creating for issue #388 * Added few helper function in order to make code more clean for issue #388 * Added changes for running commands inside docker container for issue #388 * Changed version here also * Renaming backup folder adding first unit tests * Fixed yum install command for issue #388 * Added first test run in docker container for issue #388 * Combined all actions into docker_all_run.py file for issue #388 * Fixed some issues for our docker container changed default config generator for issue #388 * Added test for taking full backup with tag for issue #388 * Added asserts for checking backup tags * Cleaning redundant code from test_backup.py * Cleaned overall project directories, removed unneeded files * fix #382. Will return error. (#391) * Code Refactoring - cleaning actions (backup and prepare sections) (#396) * Doing extra cleaning and refactoring actions for release v2.0 * Extra cleaning * It seems to be the backuper.py file successfully ended up with valid changes * Started to refactor prepare.py * while prepapre.py code refactoring - it seems to be finished at time being * Add .deepsource.toml * Removed partial recovery functionality and updated the documentation (#403) * Removed partial recovery functionality and updated the documentation accordingly * removed unused import * GeneralClass refactoring and usage changes (#406) * Finished restructuring GeneralClass into smaller methods for parsing specific options * Adding type hints to GeneralClass - still need to check with mypy * Passed mypy check for GeneralClass - the next is fixing issues with new config options * Adding Docker test and dev support (#407) * Trying to create Docker env * setup failed due to non-existing partial_recovery package * Adding command to docker compose * recent changes for docker env * unfortunately unable to complete this task - tired - dropped at time being * Finalized providing test docker container it is sufficient for local tests * trying to fix import error (#409) * trying to fix import error * Encountered another error here * Started refactoring for changing classes to use GeneralClass composition * Going further on making Backup class single responsible * Stopping here as my weekend ruined already :))) * Further refactoring - eliminating option parsing code from Backup class * Finalizing Backup class refactoring * It seems to be the Prepare now has single responsibility (#413) * It seems to be the Prepare now has single responsibility, splited functionality and extra code refactoring * the not callable object called found by deepsource.io * removed useless return statement * unnecessary else/elif removed * few changes to Dockerfile (#415) * doing code refactoring for autoxtrabackup.py (#417) * doing code refactoring for autoxtrabackup.py * trying to fix the issue with not existing key * trying to debug * adding fallback None for optional options * TypeError: expected string or bytes-like object * No option 'mysql_host' in section: 'MySQL' * No option 'data_dir' in section: 'MySQL' * Added fallbacks * tired from config parsing * remove the pdb breakpoint * trying to get rid of humanfriendly errors * Refactored and cleand check_env.py * Trying further fix the issue #416 * Removed keyword argument * Adding extra elif statement * Adding extra if statement * fixin typo in encrypt_key name * Added extra check for validating if checkpoints file was encrypted or not * first draft commit for starting to implement api (#419) * first draft commit for starting to implement api * fixing pipenv issue * trying to fix pipfile issue * fixing module not found error * test env is ready to get started with fastapi * Still struggling with Dockerizing test env * Continued to develop API for backup. Added docker compose and Dockerfile * 'Refactored by Sourcery' (#421) Co-authored-by: Sourcery AI <> * Make recent changes to send POST request to /backup and take backup respectively Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> * Prepare backup api changes (#422) * Trying to change response status codes * Added /prepare endpoint * add controller for API, modify OpenAPI doc (#426) * Refactor Dockerfile for FastAPI (#427) * add controller for API, modify OpenAPI doc * refactor Dockerfile for FastApi * refactored Dockerfile and and removed redundant env variable from docker-compose * Added extra API endpoints (#428) * Added GET endpoint for getting available backups from full and incremental backup directories * 'Refactored by Sourcery' (#429) Co-authored-by: Sourcery AI <> * finalized getting backup list * Added /delete endpoint and backup prepareness status checker for full backup * Fix for backup delete action Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> * Completely restructing the project; started to add mypy support * Completely restructing the project; started to add mypy support * Fully covered with type hints passed mypy * Added black, flake and isort support to our project * Added extra single line importer/formatter * Added pyproject.toml and flit support; shifted from Pipenv and setuptools * renamed the license file * Adding to netlify * Shahriyar r patch 1 (#435) * Add .deepsource.toml * Update README.md * Create publish.yml Co-authored-by: DeepSource Bot <bot@deepsource.io> * Doc changes trying to enable Netlify upload * Added doc fix; it was related to jinja2 * added netlify.toml changes * it seems to be we have netlify issues * change version of get-pip * small fix for pyproject.toml * trying to owercome the issue with netlify install * updated the README.md Co-authored-by: gitmstoute <mstoute@eyereturn.com> Co-authored-by: DeepSource Bot <bot@deepsource.io> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Co-authored-by: Tural <tural_m@hotmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.