Fix Localhost Port Mapping Issue #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er, add a dev env file so that when developing fireshare the frontend uses port 5000
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fireshare now correctly works on any port you map it to when running via the docker-compose.yml file. I've also updated the env files such that when running fireshare outside of docker, i.e developing on it through localhost the frontend will attempt to reach the server process on port 5000 correctly.
TL;DR
You can change the port in the docker-compose.yml file from 8080:80 to 1234:80 or :80 and it should correctly work now when you access it over localhost.