Merge pull request #673 from ShapeCrawler/next

Refactor test
ShapeCrawler · May 10, 2024 · 4720f35 · 4720f35
2 parents f2f4f79 + 9dcfe3f
commit 4720f35
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 18 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog  
 
+## Version 0.50.4 - 2024-05-10
+🐞Fixed `ISlideShapes.AddPicture()` [#671](https://github.com/ShapeCrawler/ShapeCrawler/issues/671)
+
 ## Version 0.50.3 - 2024-03-06
 🐞Fixed `IShape.AsTable()`
 

diff --git a/README.md b/README.md
@@ -89,7 +89,7 @@ Pull Requests are welcome! Please read the [Contribution Guide](https://github.c
 
 ## Changelog  
 
-### Version 0.50.3 - 2024-03-06
-🐞Fixed `IShape.AsTable()`
+### Version 0.50.4 - 2024-05-10
+🐞Fixed `ISlideShapes.AddPicture()` [#671](https://github.com/ShapeCrawler/ShapeCrawler/issues/671)
 
 Visit [CHANGELOG.md](https://github.com/ShapeCrawler/ShapeCrawler/blob/master/CHANGELOG.md) to see the full log.
diff --git a/src/ShapeCrawler/ShapeCrawler.csproj b/src/ShapeCrawler/ShapeCrawler.csproj
@@ -10,7 +10,7 @@ This library provides a simplified object model on top of the Open XML SDK for m
     <PackageTags>ShapeCrawler Presentation PPTX  PowerPoint Slides OpenXml OOXML</PackageTags>
     <NeutralLanguage>en</NeutralLanguage>
     <LangVersion>default</LangVersion>
-    <PackageReleaseNotes>Fixed IShape.AsTable()</PackageReleaseNotes>
+    <PackageReleaseNotes>Fixed ISlideShapes.AddPicture()</PackageReleaseNotes>
     <PackageProjectUrl>https://github.com/ShapeCrawler/ShapeCrawler</PackageProjectUrl>
     <RunAnalyzersDuringBuild>true</RunAnalyzersDuringBuild>
     <RepositoryType>Git</RepositoryType>

diff --git a/test/ShapeCrawler.Tests.Unit.xUnit/Helpers/TestHelper.cs b/test/ShapeCrawler.Tests.Unit.xUnit/Helpers/TestHelper.cs
@@ -12,15 +12,7 @@ static TestHelper()
         HorizontalResolution = 96;
         VerticalResolution = 96;
     }
-
-    public static MemoryStream ToResizeableStream(this byte[] byteArray)
-    {
-        var stream = new MemoryStream();
-        stream.Write(byteArray, 0, byteArray.Length);
-
-        return stream;
-    }
-
+
     public static MemoryStream GetStream(string fileName)
     {
         var assembly = Assembly.GetExecutingAssembly();

diff --git a/test/ShapeCrawler.Tests.Unit/ShapeCollectionTests.cs b/test/ShapeCrawler.Tests.Unit/ShapeCollectionTests.cs
@@ -365,9 +365,9 @@ public void AddPicture_adds_picture()
         picture.ShapeType.Should().Be(ShapeType.Picture);
         pres.Validate();
     }
-
+    
     [Test]
-    public void AddPicture_sets_dimensions()
+    public void AddPicture_adds_picture_with_correct_Height()
     {
         // Arrange
         var pres = new Presentation();
@@ -378,12 +378,10 @@ public void AddPicture_sets_dimensions()
         shapes.AddPicture(image);
 
         // Assert
-        var picture = (IPicture)shapes.Last();
-        picture.Width.Should().Be(300);
-        picture.Height.Should().Be(300);
+        var addedPicture = shapes.Last();
+        addedPicture.Height.Should().Be(300);
     }
 
-
     [Test]
     public void AddRectangle_adds_rectangle_with_valid_id_and_name()
     {