Update Zend_Rest_Route::assemble signature

[hairmare]

This is a step in the direction of making more of this work with php 7.2.

It gets rid of the Declaration of Zend_Rest_Route::assemble($data = Array, $reset = false, $encode = true) must be compatible with Zend_Controller_Router_Route_Module::assemble($data = Array, $reset = false, $encode = true, $partial = false) exception thrown when loading the rest module. It is backwards compatible with previously supported versions of php.

I'll probably have some more changes pertaining to php 7.2 since it is finally becoming the standard on most distros. Are you accepting patches on/maintaining this fork?

[hairmare]

Sorry for bugging you, I'm now focusing my efforts on the subtree splits in https://github.com/zf1s.

Thanks for your time.

[Shardj]

Thanks for bringing it up, I'll have a look later

[Shardj]

@hairmare would you recommend migration from my branch here to using needed modules from https://github.com/zf1s instead? The company I work for has a privately maintained branch from this repo here and we've been looking for a publicly maintained branch to use instead.

[hairmare]

@Shardj I seem to be the second contributor to the zf1s orga. If you join it looks like that would make three of us. Using an install that is split into multiple subpackages should make it easier to migrate away from zf1 since you can start removing the bit and pieces you don't use on a module by module base.

The app I'm still maintaining that uses zf1 is only on our intranet and I would recommend to not use zf1 in any web-facing capacity at this point.

[Shardj]

@hairmare I'm devops for a webapp which started development in 2013 using zf1, its massive and very public. The companies only product. Keeping it as up to date as possible while moving away from zf1 (to zf3 most likely) is the plan. We do have namespaces, DI, and now PHP 7.2 so it isn't all so bad. And the codebase is pretty well organised.

I'll probably move us over to zf1s too since it does seem to be a better approach.