Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use a temp fixture test file for Zend/Paginator unit test #284

Merged

Conversation

hungtrinh
Copy link

@hungtrinh hungtrinh commented Nov 16, 2022

Fixes #283

@glensc glensc changed the title phpunit - close #283 - use a temp fixture test file for unit test Fix: Use a temp fixture test file for Zend/Paginator unit test Nov 17, 2022
Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
Co-authored-by: Elan Ruusamäe <glen@pld-linux.org>
@glensc glensc force-pushed the fix-test-alway-change-test-sqlite-content branch from 4cc4287 to 0ec113f Compare November 17, 2022 09:16
@glensc
Copy link
Collaborator

glensc commented Nov 17, 2022

changed title to be readable, fixed body to use close keyword, removed tasklist (tasklist should be used to mark tasks done/not done), rewrite commit message not to include references (those belong to pull request)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test fixture file tests/Zend/Paginator/_files/test.sqlite modified everytime run unittest
2 participants