-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions phpunit on php 8.2 & Fix bug on php 8.2 #275
GitHub actions phpunit on php 8.2 & Fix bug on php 8.2 #275
Conversation
0987574
to
168a6df
Compare
Can Classes with #[AllowDynamicProperties] attribute be moved to separate PR? It's easier to review if the other changes don't span 232 files. |
it's will consume a lot of time.
|
if it was separate commit in first place, it's just cherry pick on a new branch or rebase on new branch to remove other commits |
yet you're slowing down review because the changeset in single pull request is so big to review |
why have you modified this file in this PR:
what's in it anyway? perhaps it should be reverted to value in 59ede18? |
168a6df
to
f8122d9
Compare
extracted and merged some changes that were ready:
more issues:
not fixed:
move them to separate commit so explanation is present |
f8122d9
to
0c4602c
Compare
0c4602c
to
9676af1
Compare
Extracted properties changes: and rebased this PR after its merge. you should rewrite commit message, I just put "PHP 8.2 fixes in tests" placeholder for now |
…se {$var} instead Failling test case "Zend_Reflection_FileTest::testFileGetFunctionsReturnsFunctions"
…etlocale(LC_ALL, 0) return unexpected string format. Expected string format like that: setlocale(LC_ALL, 0) === 'LC_CTYPE=en_US.UTF-8;LC_NUMERIC=C;...' Actual string format on apline container: setlocale(LC_ALL, 0) === 'C.UTF-8;C;C;C;C;C' missing part '=Something'
9676af1
to
a919093
Compare
@hungtrinh can you answer about the sqlite file: Seems I forgot to take it out, so it got merged via 65c1385. But should be resolved in future PR then. |
Mr @glensc And here it's root cause, Every time this test case run will change content of Reproceduce bug step: How to fix it, here is my idea:
If you think it's ok i will log issue and fix it |
Yes. create issue or start PR, can discuss details here. I'm thinking maybe it can be generated from scratch. |
Follow up PR #240, PR #269
This PR focus on running PHPUnit 9 on PHP 8.2 without fail test case, reduce a deprecated message when run on PHP 8.2.
To save time, i used Classes with #[AllowDynamicProperties] attribute to resolve issue
Deprecated: Creation of dynamic property {x} is deprecated
on PHP 8.2Work done
Deprecated: Creation of dynamic property {x} is deprecated
How to show all deprecated message on php 8.2 before apply this PR
Result? You will see something like that :)
Known issue