Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when I use Evernote #548

Closed
fladdict opened this issue Oct 5, 2012 · 5 comments
Closed

Crash when I use Evernote #548

fladdict opened this issue Oct 5, 2012 · 5 comments
Labels

Comments

@fladdict
Copy link

fladdict commented Oct 5, 2012

When the first time I try to auth Evernote (production mode).
The app crashes after authentification.

Tested environment is iOS6 and iPhone5.
Seems problem around present / dismiss modal view controller.

Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Attempting to begin a modal transition from <UINavigationController: 0x1e013780> to <SHKEvernote: 0x21a3c810> while a transition is already in progress. Wait for viewDidAppear/viewDidDisappear to know the current transition has completed'

*** First throw call stack:
(0x3a1ec3e7 0x34d51963 0x3a1ec29d 0x384e37b3 0x35a3e70b 0x35a3df63 0x35b5fbfb 0x93a11 0x99fd5 0x993ad 0x9a9df 0xaa8a7 0x185819 0x1855db 0x38549125 0x38488f79 0x38488e95 0x3a5c47c7 0x3a5c3eb3 0x3a5ec17b 0x3a132acd 0x3a5ec5db 0x3a550559 0x3a1c18f7 0x3a1c115d 0x3a1bff2f 0x3a13323d 0x3a1330c9 0x3a01e33b 0x359a6289 0x45c75 0x45c10)
libc++abi.dylib: terminate called throwing an exception

@fladdict
Copy link
Author

fladdict commented Oct 6, 2012

OK I finally figured out the issue.
Potentially there is two point it happens.

1:When SHKFormController appears while oAuthViewControlelr is disappearing.
2:When SHKFormController appears while SHKShareMenu is disappearing.

quick aid for this issue is changing some method call to performSelector:withObject:afterDelay:

SHKEvernote - (void)share

[self performSelector:@selector(show) withObject:nil afterDelay:0.5];

----SHKShareMenu - (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath

[sharer performSelector:@selector(share) withObject:nil afterDelay:0.5];

@VilemKurz
Copy link
Contributor

how are the steps to get the crash?

@fladdict
Copy link
Author

Simply those 2 case

A: Just logout and login evernote from ActionSheet.

B: After login to evernote, select More of ActionSheet, and choose evernote from ModalViewController.

@mattaronoff
Copy link

I'm seeing this same issue, but it's actually two-part.

The first can be reproduced by choosing Evernote from the SHKShareMenu (after logging out first if necessary); that delay is not always sufficient for every device. It really needs to wait for the menu to be gone before bringing up the OAuth page. One possible fix is to register and wait for the SHKHideCurrentViewFinishedNotification.

The second issue is that, after authentication, a similar issue occurs. Rather than calling tryPendingAction directly, it needs to wait until the OAuth controller is gone. The effect of this second issue is that the actual share sheet is never shown. Delaying this call by 0.6 seconds does seem to work on both iPhone and iPad, but also seems pretty hacky.

@VilemKurz
Copy link
Contributor

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants