Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❓🐞 Feature framework fails on AddContentTypeField (+upgrade doesn't support VersionRange?) #1219

Closed
2 of 4 tasks
andrewconnell opened this issue Jan 9, 2018 · 7 comments
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:tracked Currently tracked with Microsoft’s internal issue tracking system. DO NOT ADD/REMOVE (MSFT managed)

Comments

@andrewconnell
Copy link
Collaborator

Category

  • Question
  • Typo
  • Bug
  • Additional article idea

Expected or Desired Behavior

When leveraging the Feature Framework to provision assets, according to this doc, you should be able to not only apply element manifests but also add fields to existing content types.

Furthermore, while it isn't stated in the document above, it appears from testing & lack of mention in the docs that the <VersionRange> capability is not supported in SPFx projects... is that true?

Observed Behavior

No problem provisioning a new site column when applying the element manifest, but whenever using the AddContentTypeField element, upgrade errors out with no error details.

Upgrade eventually completes, but the version isn't incremented. When you go to the app's detail page, you see 1 upgrade error, but clicking on it yields a blank page (looking at the source of the page, can't see anything of merit).

Steps to Reproduce

  • Follow the steps in the document linked above... except instead of provisioning a list, provision a site column & content type.
  • Deploy, create the app & verify presence
  • Update project following the doc, except instead of creating a list in v2, provision a new site column & add it to the content type
  • Deploy & force the update
  • Observe error :(
@andrewconnell andrewconnell changed the title ❓🐞 Feature framework fails on AddContentTypeField (+upgrade doesn't support VersionRange)? ❓🐞 Feature framework fails on AddContentTypeField (+upgrade doesn't support VersionRange?) Jan 9, 2018
@GrahamMcMynn
Copy link

@andrewconnell - do you mind sending us the V1 and V2 of your package that doesn't add the field? That way we can ensure we are looking at the same issue you are seeing.

@GrahamMcMynn GrahamMcMynn added the status:tracked Currently tracked with Microsoft’s internal issue tracking system. DO NOT ADD/REMOVE (MSFT managed) label Jan 16, 2018
@andrewconnell
Copy link
Collaborator Author

Can you provide a way to PM link to the source? What's your email alias?

What about the <VersionRange> question... is that supported in SPFx?

@GrahamMcMynn
Copy link

@andrewconnell - Sorry about that, it's grahamc at microsoft.com.

@danwatford
Copy link

Hi @GrahamMcMynn and @andrewconnell ,

Was there any feedback regarding the possible use of (or somthing similar to) (see https://docs.microsoft.com/en-us/previous-versions/office/developer/sharepoint-2010/ee537575(v=office.14)) so that we can perform different upgrade actions depending on which version a user is updating a package from?

@danwatford
Copy link

Please ignore my last comment, I've just spotted the VersionRange element referred to on https://docs.microsoft.com/en-us/sharepoint/dev/spfx/toolchain/provision-sharepoint-assets#upgrade-sharepoint-items

@VesaJuvonen VesaJuvonen added the area:spfx Category: SharePoint Framework (not extensions related) label Nov 1, 2021
@patmill
Copy link
Contributor

patmill commented Nov 10, 2021

OK, sorry for losing track of this. I've run through a bunch of this now, and while the docs are not great (we need to improve them for sure), the VersionRange works, and the empty page on errors is due to another error (#872) being worked on. To work around it, you need to disable noscript on the site.

Here's an example of the VersionRange in the upgradeActions.xml file. In this instance, if you are upgrading from build 1.4 or newer, the new element.xml file won't be applied.

<VersionRange EndVersion="1.3.0.0">
<ApplyElementManifests>
    <ElementManifest Location="fca00b63-cabc-4ade-a9fb-fb77f5dcb3bc\newElements.xml" />
</ApplyElementManifests>
</VersionRange>

I'll close this bug down, but if you are having difficulty, please open a new issue and we will take a look at it (much sooner than before).

@patmill patmill closed this as completed Nov 10, 2021
@ghost
Copy link

ghost commented Nov 17, 2021

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues

@SharePoint SharePoint locked as resolved and limited conversation to collaborators Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:tracked Currently tracked with Microsoft’s internal issue tracking system. DO NOT ADD/REMOVE (MSFT managed)
Projects
None yet
Development

No branches or pull requests

5 participants