Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Part App Page doesn't prevent navigation when there are unsaved changes #4550

Closed
1 of 4 tasks
trey-miller opened this issue Aug 27, 2019 · 4 comments
Closed
1 of 4 tasks
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:fixed-next-drop Issue planned to be fixed in an upcoming release.
Milestone

Comments

@trey-miller
Copy link

Category

  • Question
  • Typo
  • Bug
  • Additional article idea

Expected or Desired Behavior

When editing a Single Part App Page, and there are unsaved changes, navigation should be prevented with a beforeunload confirmation prompt as it is when editing a normal Site Page.

Observed Behavior

When editing a Single Part App Page, and there are unsaved changes, navigation is not prevented.

Steps to Reproduce

  1. Create a basic SPFx web part, target the supportedHosts.SharePointFullPage in its manifest, and add a PropertyPaneCheckbox in the getPropertyPaneConfiguration method. Package and deploy the sppkg like normal.
  2. Create an app page based on the new web part.
  3. Click Edit to open the property pane.
    a. Toggle the checkbox on.
    b. Alternatively, simply change the value in the built-in Title field.
  4. Without clicking Save, click the reload button on the browser.
    a. Optionally, click the X button to close the property pane before reloading the browser.
    b. Optionally, instead of reloading the browser, click a link in the left side nav bar (e.g. the Pages list)
  5. See that navigation is not prevented/confirmed with a beforeunload event, nor with the custom dialog that SharePoint shows when doing the fast navigation.
    a. Also see that the changed checkbox value and/or Title value is not persisted.

Additional Info

When comparing with a normal Site Page, the Site Page will have a status text saying "Draft not saved" when properties have been edited, and after a few moments will say "Your page has been saved." There is no status text equivalent in an App Page, although after a few moments of toggling the checkbox, you will see the onPropertyPaneConfigurationComplete fired. Still, even after waiting for this to fire before reloading the page, the changes are not persisted.

@msft-github-bot
Copy link
Collaborator

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@msft-github-bot msft-github-bot added the Needs: Triage 🔍 Awaiting categorization and initial review. label Aug 27, 2019
@andrewconnell andrewconnell added area:spfx Category: SharePoint Framework (not extensions related) Needs: Microsoft Review 👓 and removed Needs: Triage 🔍 Awaiting categorization and initial review. labels Aug 28, 2019
@andrewconnell
Copy link
Collaborator

Talked to engineering today. This is a known issue & on the backlog to get implemented.

@andrewconnell andrewconnell added status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. and removed Needs: Microsoft Review 👓 labels Aug 28, 2019
@patmill patmill added the status:fixed-next-drop Issue planned to be fixed in an upcoming release. label Oct 26, 2021
@patmill patmill added this to the 10-29 milestone Oct 26, 2021
@AJIXuMuK AJIXuMuK removed this from the 10-29 milestone Nov 1, 2021
@AJIXuMuK AJIXuMuK removed the status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. label Nov 1, 2021
@AJIXuMuK AJIXuMuK added this to the 11-04 milestone Nov 1, 2021
@patmill
Copy link
Contributor

patmill commented Nov 16, 2021

the fix for this should now be rolled out fully

@patmill patmill closed this as completed Nov 16, 2021
@ghost
Copy link

ghost commented Nov 23, 2021

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues

@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:fixed-next-drop Issue planned to be fixed in an upcoming release.
Projects
None yet
Development

No branches or pull requests

5 participants