Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACE, CardView/QuickView markdown support on mobile #7735

Closed
2 of 9 tasks
Mikhail2k15 opened this issue Feb 20, 2022 · 5 comments
Closed
2 of 9 tasks

ACE, CardView/QuickView markdown support on mobile #7735

Mikhail2k15 opened this issue Feb 20, 2022 · 5 comments
Labels
area:ACE Issues around Adaptive Card Extensions area:ACE-Mobile area:spfx Category: SharePoint Framework (not extensions related) status:by-design Topic described is by design & not considered an issue. type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.

Comments

@Mikhail2k15
Copy link

Mikhail2k15 commented Feb 20, 2022

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

💥 SharePoint Framework

Developer environment

Windows

What browser(s) / client(s) have you tested

  • 💥 Internet Explorer
  • 💥 Microsoft Edge
  • 💥 Google Chrome
  • 💥 FireFox
  • 💥 Safari
  • mobile (iOS/iPadOS)
  • mobile (Android)
  • not applicable
  • other (enter in the "Additional environment details" area below)

Additional environment details

  • browser version
  • SPFx version 1.13.1
  • Node.js version
  • etc

Describe the bug / error

Looks like the tables, images in the markdown are not supported on mobile in a card view.

Steps to reproduce

  1. Install this sample https://github.com/pnp/sp-dev-fx-aces/blob/64c0313f8492532f846f7a3556dc9848c4fdff0e/samples/PrimaryTextCard-Covid-Indicator/src/cards/cardView/CardView.ts#L18
  2. It will look great on Web, Desktop Teams client, but will not render on both mobile clients

Session Id:385644e3-e250-4bc0-85e0-ce0032cff08e
Teams Build:1.076.2022032001
App Version:0.2.202202100137-release-vcm-FebT1
User Ring:general
SDK Version:0.9.0

Expected behavior

image
ios/android
image

A similar issue on QuickView is here pnp/sp-dev-fx-aces#43

@Mikhail2k15 Mikhail2k15 added the type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs. label Feb 20, 2022
@ghost
Copy link

ghost commented Feb 20, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 Awaiting categorization and initial review. label Feb 20, 2022
@Mikhail2k15
Copy link
Author

Mikhail2k15 commented Feb 20, 2022

@VesaJuvonen Do we have the documentation which tags in markdown we do support on CardView and Quick View?

@Mikhail2k15 Mikhail2k15 changed the title ACE, CardView mobile ACE, CardView mobile markdown support Feb 20, 2022
@Mikhail2k15 Mikhail2k15 changed the title ACE, CardView mobile markdown support ACE, CardView markdown support on mobile Feb 20, 2022
@Mikhail2k15 Mikhail2k15 changed the title ACE, CardView markdown support on mobile ACE, CardView/QuickView markdown support on mobile Feb 20, 2022
@AJIXuMuK AJIXuMuK added area:ACE Issues around Adaptive Card Extensions area:spfx Category: SharePoint Framework (not extensions related) and removed Needs: Triage 🔍 Awaiting categorization and initial review. labels Feb 22, 2022
@lucabandMSFT
Copy link
Collaborator

hey @Mikhail2k15, this is currently unsupported. Cards only support specific card views and it looks like what you are trying to do is to create your own card view. While this might work in the web, that's not working on the Mobile as the mobile enforces the view itself.

@lucabandMSFT lucabandMSFT added the status:by-design Topic described is by design & not considered an issue. label Apr 7, 2022
@Mikhail2k15
Copy link
Author

Hey @lucabandMSFT @VesaJuvonen thanks for response. My suggestion is to remove this sample pnp/sp-dev-fx-aces#43 (comment) because it provides the wrong expectations.
I have several customers and partners that were inspired with this sample but in reality there are not functional on mobile.

@ghost
Copy link

ghost commented Apr 14, 2022

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues

@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:ACE Issues around Adaptive Card Extensions area:ACE-Mobile area:spfx Category: SharePoint Framework (not extensions related) status:by-design Topic described is by design & not considered an issue. type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.
Projects
None yet
Development

No branches or pull requests

3 participants