Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPFx 1.15 - ESLint - version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree #8236

Closed
1 of 9 tasks
MarkusLanger opened this issue Jun 28, 2022 · 5 comments
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:fixed-next-drop Issue planned to be fixed in an upcoming release. type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.
Milestone

Comments

@MarkusLanger
Copy link

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

💥 SharePoint Framework

Developer environment

macOS

What browser(s) / client(s) have you tested

  • 💥 Internet Explorer
  • 💥 Microsoft Edge
  • 💥 Google Chrome
  • 💥 FireFox
  • 💥 Safari
  • mobile (iOS/iPadOS)
  • mobile (Android)
  • not applicable
  • other (enter in the "Additional environment details" area below)

Additional environment details

  • browser version: Version 103.0.5060.53
  • SPFx version: 1.15 GA
  • Node.js version: 16.15.1
  • ESLint version: 8.18.0
  • TypeScript version 4.7.4

Describe the bug / error

When I run the eslint command eslint src/* --ext js,ts,tsx I get the following warning:

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.6.0

YOUR TYPESCRIPT VERSION: 4.7.4

Please only submit bug reports when using the officially supported version.

image

Steps to reproduce

  1. Create a new SPFx Project with version 1.15 GA
  2. Install deps with npm install
  3. Run ESLint with eslint src/* --ext js,ts,tsx

Expected behavior

I would expect that ESLint runs without warning.

@MarkusLanger MarkusLanger added the type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs. label Jun 28, 2022
@ghost
Copy link

ghost commented Jun 28, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 Awaiting categorization and initial review. label Jun 28, 2022
@AJIXuMuK
Copy link
Collaborator

@MarkusLanger -thanks for reporting this one.
eslint tasks is baked in in the build routing so technically you don't need to call it separately.
And when executed as part of the build routine, it uses TS v 4.5.5.

Although we definitely need to explicitly specify the version of TS in the package.json to avoid installing another version.

@AJIXuMuK AJIXuMuK added area:spfx Category: SharePoint Framework (not extensions related) and removed Needs: Triage 🔍 Awaiting categorization and initial review. labels Jun 28, 2022
@MarkusLanger
Copy link
Author

I have been using ESLint in my projects for a long time. That's why I have my own NPM script for it.

Looks like the higher version comes from "@rushstack/eslint-config".
image

@AJIXuMuK AJIXuMuK added the status:fixed-next-drop Issue planned to be fixed in an upcoming release. label Jul 11, 2022
@AJIXuMuK AJIXuMuK added this to the 1.15.0-next milestone Jul 11, 2022
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Aug 2, 2022

1.15.2 is out - this should be fixed

@AJIXuMuK AJIXuMuK closed this as completed Aug 2, 2022
@ghost
Copy link

ghost commented Aug 9, 2022

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues

@ghost ghost locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:fixed-next-drop Issue planned to be fixed in an upcoming release. type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.
Projects
None yet
Development

No branches or pull requests

2 participants