🐞SPFx - Update package-solution.json's schema to include optional properties for webApiPermissionRequests

[andrewconnell]

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

💥 SharePoint Framework

Developer environment

No response

What browser(s) / client(s) have you tested

• 💥 Internet Explorer
• 💥 Microsoft Edge
• 💥 Google Chrome
• 💥 FireFox
• 💥 Safari
• mobile (iOS/iPadOS)
• mobile (Android)
• not applicable
• other (enter in the "Additional environment details" area below)

Additional environment details

• SPFx v1.15.2 projects

Describe the bug / error

The schema for ./config/package-solution.json, https://developer.microsoft.com/json-schemas/spfx-build/package-solution.schema.json, is missing optional properties on objects in the webApiPermissionRequests array introduced in SPFx v1.15.2: appId & replyUrl.

This means developers won't get IntelliSense with included docs when editing this file. In fact, the file will fail validation as it currently contains additionalProperties: false which will say the properties aren't allowed:

Steps to reproduce

1. Create new project

2. Use any type of component when prompted

3. Open said project in VSCode

4. Open ./config/package-solution.json

5. Add the following code after the developer property:

   "webApiPermissionRequests": [
     {
       "scope": "", "resource": "", "appId": "asd", "replyUrl": "https://foo.com/endpoint"
     }
   ],

6. Developer curses at VSCode and 😭 in solitude... kittens rush for safety to avoid being kicked by said developer.

Expected behavior

1. Create new project

2. Use any type of component when prompted

3. Open said project in VSCode

4. Open ./config/package-solution.json

5. Add the following code after the developer property:

   "webApiPermissionRequests": [
     {
       "scope": "", "resource": "", "appId": "asd", "replyUrl": "https://foo.com/endpoint"
     }
   ],

6. Observe IntelliSense when modifying values under the included webApiPermissionRequests

7. The Microsoft engineer who took the time to update this file, on their way home from work to enjoy a good streaming movie, when picking up their take-out tacos 🌮, comes to find out someone paid it forward as thanks and now they enjoy free 🌮 for their contribution to developers across the globe.

[ghost]

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

[AJIXuMuK]

Thanks @andrewconnell for reporting it!
the issue is now fixed.

[ghost]

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues