Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-paged Webpart Property Panes - Pagination doesn't work as expected, stopping users from accessing pages #8483

Closed
1 of 9 tasks
tandrasi opened this issue Oct 6, 2022 · 20 comments
Assignees
Labels
area:spfx Category: SharePoint Framework (not extensions related) react-17 status:fixed-next-drop Issue planned to be fixed in an upcoming release. type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.
Milestone

Comments

@tandrasi
Copy link

tandrasi commented Oct 6, 2022

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

💥 SharePoint Framework

Developer environment

Windows

What browser(s) / client(s) have you tested

  • 💥 Internet Explorer
  • 💥 Microsoft Edge
  • 💥 Google Chrome
  • 💥 FireFox
  • 💥 Safari
  • mobile (iOS/iPadOS)
  • mobile (Android)
  • not applicable
  • other (enter in the "Additional environment details" area below)

Additional environment details

Hi, I was told by a contributor of the PnP Modern Search repo (https://github.com/microsoft-search/pnp-modern-search) to duplicate a bug we found here as they suspect it is an SPFx issue.

Describe the bug / error

Hi, I was told by a contributor of the PnP Modern Search repo (https://github.com/microsoft-search/pnp-modern-search) to duplicate a bug we found here as they suspect it is an SPFx issue.

The bug in question is the following: microsoft-search/pnp-modern-search#2405. It has gained a lot of traction in the last couple of days as it seems to only have started occurring this week - regardless of version of the PnP Modern Search web parts used.

Here is the original post that started it all by user twodul

Describe the bug

On the search result web part configuration property pane,
1 of 4 : next button working so can see the 2nd page
2 of 4 : when I click next button it go to "1 of 4" page not "3 of 4" page.
I can't set up available connection from 3rd page configuration.

It works fine with my test tenant environment and this issue happens only on our production environments.

I got below JavaScript error when I click next button.
image

I attached the console log messages. SearchResultsPropertyPannelErrorLog.txt

image

Steps to reproduce

  1. Add PnP Modern Search "Search Results" or "Search Filters" web parts to a page.
  2. Edit the web part and try access page 3 or 4 of the property pane.
  3. Pages 3 or 4 are not accessible on those web parts -> clicking on "next" on Page 2, will loop back to Page 1.

Expected behavior

  1. Panel page should increment to page 3 and 4 when required.
@tandrasi tandrasi added the type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs. label Oct 6, 2022
@ghost
Copy link

ghost commented Oct 6, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@Georg-Trixl
Copy link

I got the same problem, with Chrome, Egde and Firefox - all in latest stable Version

@Kanamo
Copy link

Kanamo commented Oct 6, 2022

I got the same problem in three diferent tenants

@tandrasi tandrasi changed the title Multi-paged Webpart Property Panes - Pagination doesn't work as expected, stopping users from access pages Multi-paged Webpart Property Panes - Pagination doesn't work as expected, stopping users from accessing pages Oct 6, 2022
@AJIXuMuK AJIXuMuK added area:spfx Category: SharePoint Framework (not extensions related) and removed Needs: Triage 🔍 Awaiting categorization and initial review. labels Oct 6, 2022
@AJIXuMuK AJIXuMuK self-assigned this Oct 6, 2022
@FranckyC
Copy link
Contributor

FranckyC commented Oct 6, 2022

@AJIXuMuK FYI, this specific page is all about SPFx dynamic data, listing available data sources and retrieving existing connections if it can help to identify the cause.

@ekdegerman
Copy link

This recently started happening to us too. After another issue we faced today, I realized that it seems the common denominator for the tenants it happens in is that SharePoint is now using React 17. Tenants still using 16.13.1 still work fine. Hope this can help give a clue...
image

@AJIXuMuK
Copy link
Collaborator

The fix has been done and should roll out in the next 2 weeks.

@AJIXuMuK AJIXuMuK added the status:fixed-next-drop Issue planned to be fixed in an upcoming release. label Oct 10, 2022
@AJIXuMuK AJIXuMuK added this to the 10-07 milestone Oct 10, 2022
@KuotingChiu
Copy link

@AJIXuMuK , how is this fix being rolled out? It is a SharePoint Online release update? Any client side alternative possible ?

@AJIXuMuK
Copy link
Collaborator

@KuotingChiu - this is service-side update.
We will roll out new version 100% next Monday.
You won't need to do any changes.

@KuotingChiu
Copy link

@AJIXuMuK , our developer's initial confirmation is positive, Thanks a lot!!! May I ask if this type of changes to break and fix the issue was announced such as using the M365 message center at all? We have a support incident opened for this issue and the assigned support person as well as the incident escalation manager were not helpful at all.

@AJIXuMuK
Copy link
Collaborator

@KuotingChiu - these changes were not announced as our understanding was the React update will go smooth. Unfortunately, we were wrong.
We're working on some adjustments to our announcements and rollout processes to avoid such problems in the future.

@rogbac
Copy link

rogbac commented Oct 18, 2022

@AJIXuMuK "Next Monday", does that mean Monday October 24th to be clear? We have customers with applications that are down due to this so they need to be informed.

@AJIXuMuK
Copy link
Collaborator

@rogbac - next Monday is yesterday

@rogbac
Copy link

rogbac commented Oct 18, 2022

Ok thanks, then we hope to see a change to the positive anytime soon. Still same in the customer tenants experiencing this.

@AJIXuMuK
Copy link
Collaborator

@rogbac - that should be already there.
I would try opening the browser page in incognito (Private) mode to see if the error is there.
Also - is that the same error as described in this issue? Or some other kind of error?

@KuotingChiu
Copy link

Our tenant seems to be fine now. Isn't this change applied to all tenants?

@AJIXuMuK
Copy link
Collaborator

@KuotingChiu - it is applied to all tenants.
I strongly believe @rogbac has some other type of the issue.
I will close this one.
@rogbac - feel free to create a new issue with detailed description of what's happening for you.

@FranckyC
Copy link
Contributor

Thanks for the fix BTW @AJIXuMuK !

@rogbac
Copy link

rogbac commented Oct 20, 2022

Just some feedback in this thread. NOW it works for us again, we noticed it today in several tenants (Swedish customers) that it just started to work again today without any action/workaround. Previously today we still had the error described in this thread, but sometime the last hours it fixed it itself. So the rollout/rollback has not been global on the same day for everyone as feedback. Happy it works again though @AJIXuMuK

@AJIXuMuK
Copy link
Collaborator

@rogbac - the rollout was global.
The thing here that potentially you could have cache (most probably service worker) that loaded old modules.

@ghost
Copy link

ghost commented Oct 28, 2022

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues

@ghost ghost locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:spfx Category: SharePoint Framework (not extensions related) react-17 status:fixed-next-drop Issue planned to be fixed in an upcoming release. type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.
Projects
None yet
Development

No branches or pull requests

8 participants