Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Control: Search Query Control #23

Closed
nanddeepn opened this issue Dec 19, 2017 · 13 comments
Closed

New Control: Search Query Control #23

nanddeepn opened this issue Dec 19, 2017 · 13 comments
Labels
help wanted type:enhancement New feature or enhancement of existing capability

Comments

@nanddeepn
Copy link
Contributor

[x ] Enhancement

[ ] Bug

[ ] Question

Property control to query the search results.
Similar to Search Results in classic SharePoint.

Thanks!

@AsishP
Copy link
Contributor

AsishP commented Mar 5, 2018

This is an interesting requirement. I have a similar one upcoming at my client. Would be happy to pick this one up after the people picker, if not picked already.

@nanddeepn
Copy link
Contributor Author

Not started yet. Please let me know, if I can be of any help during implementation

@estruyf
Copy link
Member

estruyf commented Mar 5, 2018

@AsishP @nanddeepn not yet assigned to someone, so feel free to contribute.

@AsishP
Copy link
Contributor

AsishP commented Mar 5, 2018

Thanks @estruyf.

Yeah sure @nanddeepn, what are you thoughts on the scope. I think it would be good for us to scope the requirements for this control because the SharePoint classic search results page can do many scenarios and includes refiners, result sources etc which could get complex soon.

As per me, to start we built an initial keyword based search box control with scoping to all enterprise results and display them in a card view allowing paging of results. Thoughts?

@nanddeepn
Copy link
Contributor Author

Hi, Sorry for seeing this late.
Yes, SharePoint classic search offers a lot. We can start with keyword based search and display them in cards view.

@AsishP
Copy link
Contributor

AsishP commented May 9, 2018

Hi @estruyf, @nanddeepn , I am completed with the people picker and starting with this control. I suppose cards are a great idea, but would they be more horizontal cards (as in Teams) or vertical cards (as in Document cards). I suppose horizontal cards in the same layout as classic search would work?

Another similar component, we have implemented for a project is a search control with modal results. Below is the screenshot. How does that look?

On property pane, what could be the options - result sources? managed properties? site level? list?

Also request others share ideas. There is a lot of potential that this control could add.

image

@nanddeepn
Copy link
Contributor Author

@AsishP , That's great!
In the property pane, lets have Result sources as of now.

@estruyf
Copy link
Member

estruyf commented May 10, 2018

Looks like a really good control.

About the properties, make it as extensible as possible.

Great work!

@AsishP
Copy link
Contributor

AsishP commented May 10, 2018

Thanks @estruyf and @nanddeepn for the feedback. Will share updated screenshots as soon as got something ready.

@AJIXuMuK
Copy link
Collaborator

Hi @nanddeepn, @AsishP - just checking if it's still somewhere in progress? :)

@nanddeepn
Copy link
Contributor Author

Hi @AJIXuMuK
Almost 3 years ago, when it was started. No recent updates on this and nothing in progress from my side. But please let me know, if anything to be done here.
Thank you.

@sympmarc
Copy link

One would think these requirements have been covered by the PnP Modern Search solution ? Differently, sure, but us there a need to rebuild?

@AJIXuMuK
Copy link
Collaborator

I agree @sympmarc. Just wanted to check first to not lose existing job before closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

6 participants