Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebPartTitle add support for section background color #258

Closed
jonathanhotono opened this issue Mar 25, 2019 · 3 comments
Closed

WebPartTitle add support for section background color #258

jonathanhotono opened this issue Mar 25, 2019 · 3 comments
Milestone
1.14.0

Comments

@jonathanhotono
Copy link

jonathanhotono commented Mar 25, 2019 •
edited
Loading

Category

[ x ] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 1.12.0 ]

Can we add support to section backgrounds font color for WebPartTitle ?
image

Probably need user to optionally add a themeVariant object into the component optionally, and if themeVariant object exist we use themeVariant.semanticColor.bodyText
https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/guidance/supporting-section-backgrounds
@mpowney
Copy link

mpowney commented May 25, 2019

Hi @estruyf - this sounds like a useful enhancement to make. I'd be happy to pick this up as my first contribution to this project, any thoughts?

@mpowney mpowney mentioned this issue May 28, 2019
Merged
@estruyf estruyf added this to the 1.14.0 milestone Jul 9, 2019
@estruyf
Copy link
Member

estruyf commented Jul 9, 2019

The PR from @mpowney just got merged, and this change will be available in version 1.14.0.

If you want, you can already test it out via installing the latest beta version. More information about how to install a beta version can be found here: https://sharepoint.github.io/sp-dev-fx-controls-react/beta/

@estruyf estruyf mentioned this issue Jul 17, 2019
Merged
@estruyf
Copy link
Member

estruyf commented Jul 18, 2019

This is now included within the 1.14.0 release

@estruyf estruyf closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.0
Development

No branches or pull requests
3 participants
@estruyf @jonathanhotono @mpowney