Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add themeVariant and color props to WebPartTitle #316

Merged

Conversation

mpowney
Copy link

@mpowney mpowney commented May 28, 2019

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues? fixes #258

What's in this Pull Request?

Two new properties have been added to the webPartTitle control:

  • color
  • themeVariant

Either can be used to override the colour of the web part title, to support section backgrounds.

When following the published guidance on enabling section backgrounds, the themeVariant property can be supplied to the webPartTitle component to apply the appropriate color.

Alternatively, the color property can be supplied to provide a direct override of the web part title's foreground color.

@codecov-io
Copy link

Codecov Report

Merging #316 into dev will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #316      +/-   ##
==========================================
+ Coverage   72.84%   72.88%   +0.03%     
==========================================
  Files          17       17              
  Lines         766      767       +1     
  Branches      148      149       +1     
==========================================
+ Hits          558      559       +1     
  Misses        161      161              
  Partials       47       47
Impacted Files Coverage Δ
src/controls/webPartTitle/WebPartTitle.tsx 87.5% <100%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0df446...aeddd6e. Read the comment docs.

@estruyf
Copy link
Member

estruyf commented Jun 5, 2019

@mpowney thank you very much for this! I'll merge this soon.

@estruyf estruyf merged commit aeddd6e into pnp:dev Jul 9, 2019
estruyf added a commit that referenced this pull request Jul 9, 2019
@estruyf
Copy link
Member

estruyf commented Jul 9, 2019

Thanks @mpowney, this will be available in 1.14.0. I did a change to remove the color property, as this could be better achieved by specifying a custom class (which was already supported).

@estruyf estruyf added this to the 1.14.0 milestone Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants