Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTimePicker does not respect dateLabel and timeLabel #346

Closed
robert-lindstrom opened this issue Jul 29, 2019 · 2 comments
Closed

DateTimePicker does not respect dateLabel and timeLabel #346

robert-lindstrom opened this issue Jul 29, 2019 · 2 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone
1.15.0

Comments

@robert-lindstrom
Copy link
Contributor

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [latest]

Expected / Desired Behavior / Question

Setting the dateLabel and timeLabel strings as shown below has no effect on the DateTimePicker component.

<DateTimePicker strings={{ dateLabel: 'date lbl', timeLabel: 'time lbl', ...  }} ... />

This is expected to update the respective labels of the DateTimePicker component.

Observed Behavior

Setting the dateLabel and timeLabel properties has no effect to the component.

Steps to Reproduce

See above!
@ghost
Copy link

ghost commented Jul 29, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jul 29, 2019
@robert-lindstrom robert-lindstrom mentioned this issue Jul 29, 2019
Merged
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed Needs: Triage 🔍 labels Oct 9, 2019
@AJIXuMuK AJIXuMuK added this to the 1.15.0 milestone Oct 9, 2019
@estruyf estruyf mentioned this issue Oct 14, 2019
Merged
@estruyf
Copy link
Member

estruyf commented Oct 14, 2019

Closing this issue as version 1.15.0 has just been released.

@estruyf estruyf closed this as completed Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
3 participants
@estruyf @AJIXuMuK @robert-lindstrom