Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DateTimePicker respect dateLabel and timeLabel #347

Conversation

robert-lindstrom
Copy link
Contributor

DateTimePicker now makes use of the dateLabel and timeLabel properties
of the object passed in the strings prop.

Q A
Bug fix? [X]
New feature? [ ]
New sample? [ ]
Related issues? fixes #346

What's in this Pull Request?

DateTimePicker now uses the dateLabel and timeLabel properties of the object passed in the strings prop.

DateTimePicker now makes use of the dateLabel and timeLabel properties
of the object passed in the strings prop.
@codecov-io
Copy link

Codecov Report

Merging #347 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #347   +/-   ##
=======================================
  Coverage   72.88%   72.88%           
=======================================
  Files          17       17           
  Lines         767      767           
  Branches      149      149           
=======================================
  Hits          559      559           
  Misses        161      161           
  Partials       47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb2e99...1acac33. Read the comment docs.

@estruyf estruyf merged commit 1acac33 into pnp:dev Sep 3, 2019
@estruyf estruyf added this to the 1.15.0 milestone Sep 3, 2019
@estruyf
Copy link
Member

estruyf commented Sep 3, 2019

Thanks @robert-lindstrom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants