Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeoplePicker doesn't show mandatory asterisk in label when isRequired={true} #371

Closed
mfdezvil opened this issue Sep 19, 2019 · 2 comments

Comments

@mfdezvil
Copy link

@mfdezvil mfdezvil commented Sep 19, 2019

Category

[ ] Enhancement

[ X] Bug

[ X] Question

Version

1.14.0 (latest release)

Expected / Desired Behavior / Question

If "isRequired" is set to true in PeoplePicker component, mandatory asterisk should appear in label, as other office-ui-fabric-react components. Doesn't it?

Observed Behavior

When I implement a PeoplePicker component and set "isRequired={true}", mandatory asterisk doesn't appear in label.

Steps to Reproduce

Create a PeoplePicker component and a TextField component in a SPFX WebPart with this code:

<TextField id="TxtField" label="Text Field" onChange={this.onChangePageTitle} required={true} /> <PeoplePicker context={this.props.context} titleText="People Picker" personSelectionLimit={1} groupName={""} isRequired={true} selectedItems={this._getPeoplePickerItems} showHiddenInUI={false} principalTypes={[PrincipalType.User]} resolveDelay={1000} />

As you can see, "isRequired"/"required" properties are set to true in both components. However, when webpart is rendered, label only shows a mandatory asterisk in TextField. Shouldn't the asterisk show in both components?

@msftbot

This comment has been minimized.

Copy link

@msftbot msftbot bot commented Sep 19, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

siata13 pushed a commit to siata13/sp-dev-fx-controls-react that referenced this issue Sep 26, 2019
AJIXuMuK added a commit that referenced this issue Oct 9, 2019
#371 Fix missing required field label.
@AJIXuMuK AJIXuMuK added this to the 1.15.0 milestone Oct 9, 2019
@estruyf

This comment has been minimized.

Copy link
Collaborator

@estruyf estruyf commented Oct 14, 2019

Closing this issue as version 1.15.0 has just been released.

@estruyf estruyf closed this Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.