Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added suport for where you have custom sorted taxonomy collections #147

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

trillian74
Copy link

Q A
Bug fix? [ ]
New feature? [ X]
New sample? [ ]
Related issues? fixes #146 , mentioned in #146

What's in this Pull Request?

The taxonomypicker didnt support your custom term store sorting settings, with this change it automatically applies the custom sort

BR
Ole

@msftclas
Copy link

msftclas commented Oct 5, 2018

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link

Codecov Report

Merging #147 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #147   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       78       78           
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9eb35e...e69b0b9. Read the comment docs.

@estruyf estruyf merged commit e69b0b9 into pnp:dev Oct 15, 2018
@estruyf estruyf added this to the 1.10.0 milestone Oct 15, 2018
@estruyf
Copy link
Member

estruyf commented Oct 15, 2018

Thanks @trillian74 for the PR. Your code changes have been merged and will be available in the 1.10.0 beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants