Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFramePanel implemenation #226

Merged
merged 4 commits into from Feb 7, 2019

Conversation

Projects
None yet
5 participants
@spdavid
Copy link
Contributor

spdavid commented Jan 22, 2019

Q A
Bug fix? [ ]
New feature? [X ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

New Implemenation of an IFramePanel control Similar to the IFrameDialog except renders an IFrame in a Fabric UI Panel. Did not open a discussion for this but I needed to build it anyway. Add it if everyone feels its a good idea.

Has a nice dynamic height if the height is not set. Tested in IE, Chrome, Edge.

David Opdendries added some commits Jan 22, 2019

@AJIXuMuK

This comment has been minimized.

Copy link
Contributor

AJIXuMuK commented Feb 2, 2019

HI @spdavid!
Could you please check the error from CircleCI:

[21:47:50] Error - [webpack] 'dist':
./lib/controls/iFramePanel/IFramePanel.js
Module not found: Error: Can't resolve './IframePanelContent' in '/home/circleci/sp-dev-fx-controls-react/lib/controls/iFramePanel'
resolve './IframePanelContent' in '/home/circleci/sp-dev-fx-controls-react/lib/controls/iFramePanel'
  using description file: /home/circleci/sp-dev-fx-controls-react/package.json (relative path: ./lib/controls/iFramePanel)
    Field 'browser' doesn't contain a valid alias configuration
  after using description file: /home/circleci/sp-dev-fx-controls-react/package.json (relative path: ./lib/controls/iFramePanel)
    using description file: /home/circleci/sp-dev-fx-controls-react/package.json (relative path: ./lib/controls/iFramePanel/IframePanelContent)
      no extension
        Field 'browser' doesn't contain a valid alias configuration
        /home/circleci/sp-dev-fx-controls-react/lib/controls/iFramePanel/IframePanelContent doesn't exist
      .js
        Field 'browser' doesn't contain a valid alias configuration
        /home/circleci/sp-dev-fx-controls-react/lib/controls/iFramePanel/IframePanelContent.js doesn't exist
      .json
        Field 'browser' doesn't contain a valid alias configuration
        /home/circleci/sp-dev-fx-controls-react/lib/controls/iFramePanel/IframePanelContent.json doesn't exist
      as directory
        /home/circleci/sp-dev-fx-controls-react/lib/controls/iFramePanel/IframePanelContent doesn't exist

spfolkis and others added some commits Feb 2, 2019

David Opdendries David Opdendries
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 2, 2019

Codecov Report

Merging #226 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #226   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          16       16           
  Lines         744      744           
  Branches      138      148   +10     
=======================================
  Hits          541      541           
  Misses        159      159           
  Partials       44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6985a86...e3ca2b5. Read the comment docs.

@spdavid

This comment has been minimized.

Copy link
Contributor Author

spdavid commented Feb 2, 2019

@AJIXuMuK All checks now passed.

@estruyf estruyf merged commit e3ca2b5 into SharePoint:dev Feb 7, 2019

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.
Details

estruyf added a commit that referenced this pull request Feb 7, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Feb 7, 2019

Thanks @spdavid, I did some code changes to the control for consistency, but also for retrieving the parent element by the className. Control has been merged and will be available in v1.12.0.

@estruyf estruyf added this to the 1.12.0 milestone Feb 7, 2019

@estruyf estruyf referenced this pull request Feb 22, 2019

Merged

Prepare 1.12.0 release #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.