Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTimePicker layout problem in IE 11 #301

Closed
robert-lindstrom opened this issue May 15, 2019 · 3 comments
Closed

DateTimePicker layout problem in IE 11 #301

robert-lindstrom opened this issue May 15, 2019 · 3 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone

Comments

@robert-lindstrom
Copy link
Contributor

Category

[ ] Enhancement

[X] Bug

[ ] Question

Version

Please specify what version of the library you are using: [latest]

Expected / Desired Behavior / Question

The time row of the DateTimePicker should stay within its area
DateTimePickerLayoutOk

Observed Behavior

The time row of the DateTimePicker overflows in IE 11 (se picture) due to issues with flexbox layout.
DateTimePickerLayoutIssue

Steps to Reproduce

Put two DateTimePickers next to each other in a grid and check layout using IE 11:

<div className="ms-Grid-row">
  <div className="ms-Grid-col ms-lg6">
    <DateTimePicker label="DateTime Picker without seconds" showSeconds={false} onChange={(value) => console.log("DateTimePicker value:", value)} />
  </div>
  <div className="ms-Grid-col ms-lg6">
    <DateTimePicker label="DateTime Picker with seconds" showSeconds={true} onChange={(value) => console.log("DateTimePicker value:", value)} />
  </div>
</div>

Thanks!

@ghost
Copy link

ghost commented May 15, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@estruyf
Copy link
Member

estruyf commented May 15, 2019

Thanks @robert-lindstrom for reporting and fixing this.

@estruyf estruyf added status:fixed-next-drop Issue will be fixed in upcoming release. and removed Needs: Triage 🔍 labels May 15, 2019
@estruyf estruyf added this to the 1.13.2 milestone May 17, 2019
@estruyf
Copy link
Member

estruyf commented May 22, 2019

This has just been released in version 1.13.2

@estruyf estruyf closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

No branches or pull requests

2 participants