Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with DateTimePicker layout in IE 11 #302

Merged
merged 1 commit into from
May 17, 2019

Conversation

robert-lindstrom
Copy link
Contributor

Q A
Bug fix? [X]
New feature? [ ]
New sample? [ ]
Related issues? fixes #301

What's in this Pull Request?

This fixes the layout problem mentioned in issue #301.

The implementation adds flex-basis: 0%; to the picker css class. This fixes the layout issues seen in IE 11 and is needed because IE 11 does not fully comply with the flexbox standard.

@codecov-io
Copy link

Codecov Report

Merging #302 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #302   +/-   ##
=======================================
  Coverage   72.36%   72.36%           
=======================================
  Files          17       17           
  Lines         760      760           
  Branches      157      157           
=======================================
  Hits          550      550           
  Misses        163      163           
  Partials       47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a8337...4b4ee8c. Read the comment docs.

@estruyf estruyf merged commit fabc82c into pnp:dev May 17, 2019
@estruyf estruyf modified the milestones: 1.13.1, 1.13.2 May 17, 2019
@estruyf
Copy link
Member

estruyf commented May 17, 2019

Thanks @robert-lindstrom for fixing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants