Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide callout from the controls with callout if no message is provided #107

Closed
1 of 3 tasks
estruyf opened this issue Oct 30, 2018 · 1 comment
Closed
1 of 3 tasks

Hide callout from the controls with callout if no message is provided #107

estruyf opened this issue Oct 30, 2018 · 1 comment
Milestone
1.12.0

Comments

@estruyf
Copy link
Member

estruyf commented Oct 30, 2018

Category

  • Enhancement
  • Bug
  • Question

Version

Please specify what version of the library you are using: [all]

Expected / Desired Behavior / Question

When the message is empty for a callout control, the callout icon is still displayed. It would be better to hide the icon when no message is provided.

PR #106 from @erwinvanhunen includes this change.
estruyf added a commit that referenced this issue Oct 30, 2018
@estruyf
#106 #107 - Small code change
bcb760d
@estruyf estruyf added this to the 1.12.0 milestone Oct 30, 2018
@estruyf estruyf mentioned this issue Nov 14, 2018
Merged
@estruyf
Copy link
Member Author

estruyf commented Nov 14, 2018

Version 1.12.0 has just been released.

@estruyf estruyf closed this as completed Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0
Development

No branches or pull requests
1 participant
@estruyf