PropertyFieldCodeEditor- Handle initial value update when new props

[FranckyC]

In the PropertyFieldCodeEditor field, the initial value is only set at mount time and can't be updated afterwards. It could useful to handle the value update when receiving new props.

This scenario happens in the react-search-refiners sample when the user chooses a different layout resulting to initial value to be updated for the selected layout.

Category

• [ X] Enhancement
• Bug
• Question

Version

Latest

[estruyf]

Thanks @FranckyC, will be updated in v1.13.0.

[estruyf]

A fix has just been added for this issue. Feel free to test out the latest beta to check if it is fixed for your solution. More information about installing a beta version can be found here: https://sharepoint.github.io/sp-dev-fx-property-controls/beta/

[FranckyC]

Thanks @estruyf! I'll test this ASAP.

[FranckyC]

@estruyf Unfortunately, it doesn't work. After reviewing your commit it seems you take props instead of nextProps when setting the new code value. Should it be nextProps instead?

this.setState({
        code: typeof this.props.initialValue !== 'undefined' ? this.props.initialValue : ''
      });

[estruyf]

My mistake will update it right away.

[estruyf]

Fix is in, and the beta release should be out in any minute now.

[FranckyC]

Works like a charm! Thanks @estruyf

[DanSantoDomingo]

Hello im new to sharepoint framework and react.. what i want to do is set the webpart code as the initial value.. i tried putting this.domElement but wont work.. also what should i put inside the onPropertyChange to save the changes?