Replace jitsi_meet package with jitsi_meet_wrapper + increase iOS deployment target to 12.0
#164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 3873b05): https://sharezone-test--pr164-switch-jitsi-package-0m5liv5w.web.app (expires Sat, 14 May 2022 09:35:41 GMT) 馃敟 via Firebase Hosting GitHub Action 馃寧 |
Jonas-Sander
approved these changes
May 6, 2022
|
You said it didn't work on Android yet? |
|
Android is working :) I added a screenshot to the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm sure that the
jitsi_meetpackage is the reason why the iOS build is failing in #153. The problem is that thejitsi_meetpackage isn't maintained anymore. So it's difficult to find a fix so that #153 can be merged.There are also several issues that Android 12 is not supported anymore by the package (gunschu/jitsi_meet#376, gunschu/jitsi_meet#368, gunschu/jitsi_meet#366).
There is a folk of
jitsi_meetcalledjitsi_meet_wrapperwhich has better code and is maintained. So I migrated to this package (thanks to @saibotma 馃挋).One big disadvantage:
jitsi_meet_wrapperuses the current Jitsi iOS SDK which requires +12.0. This means we need to drop the support for iOS 11.0 (other option would be to remove the Jitsi Feature for all users) 馃槥Demo
ToDo