Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note to the README.md how to compile your Android app for a lower SDK version #32

Conversation

nilsreichardt
Copy link
Contributor

A proposal for better documentation: There might the case where videoconferences are just one of many features in your app. In this case it could be bad, if you need to increase the minium SDK version for all users, even when only a small set of users are using the videoconference feature.

Copy link
Owner

@saibotma saibotma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Found some minor, rather cosmetic, issues. Did not test this, but I assume you tested this with Sharezone, didn't you?

jitsi_meet_wrapper/README.md Show resolved Hide resolved
jitsi_meet_wrapper/README.md Outdated Show resolved Hide resolved
jitsi_meet_wrapper/README.md Outdated Show resolved Hide resolved
nilsreichardt and others added 2 commits May 9, 2022 07:55
Co-authored-by: Tobias Marschall <tobias.marschall@online.de>
Co-authored-by: Tobias Marschall <tobias.marschall@online.de>
jitsi_meet_wrapper/README.md Show resolved Hide resolved
@saibotma saibotma merged commit c2305b6 into saibotma:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants