Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add included files to the MSBuild Up-to-Date checks. #106

Merged
merged 3 commits into from
Apr 15, 2019

Conversation

jkoritzinsky
Copy link
Member

Add included files to MSBuild up-to-date checks so incremental builds will update when the native headers change.

Clean up support for P2P dependencies that aren't referencing SharpGen.

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #106 into master will decrease coverage by 2.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   58.61%   56.49%   -2.12%     
==========================================
  Files         150      150              
  Lines        9168     9172       +4     
  Branches     1123     1642     +519     
==========================================
- Hits         5374     5182     -192     
- Misses       3406     3410       +4     
- Partials      388      580     +192
Impacted Files Coverage Δ
SharpGen/Parser/MacroManager.cs 98.3% <100%> (+0.09%) ⬆️
SharpGen/Generator/StructCodeGenerator.cs 63.63% <0%> (-36.37%) ⬇️
...harpGen/Generator/NativeInvocationCodeGenerator.cs 67.3% <0%> (-32.7%) ⬇️
SharpGen/Transform/ConstantManager.cs 67.53% <0%> (-20.78%) ⬇️
SharpGen/Generator/InterfaceCodeGenerator.cs 26.61% <0%> (-17.34%) ⬇️
SharpGen/Model/CsMarshalBase.cs 58.33% <0%> (-16.67%) ⬇️
SharpGen/Generator/RoslynGenerator.cs 69.52% <0%> (-12.39%) ⬇️
SharpGen/Generator/Marshallers/MarshallerBase.cs 40.95% <0%> (-11.27%) ⬇️
SharpGen/Model/CsMethod.cs 65% <0%> (-10%) ⬇️
SharpGen/Model/CsInterface.cs 86.95% <0%> (-8.7%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11088e...85c7143. Read the comment docs.

@jkoritzinsky jkoritzinsky merged commit af9bc2e into master Apr 15, 2019
@jkoritzinsky jkoritzinsky deleted the msbuild-cleanup branch April 15, 2019 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant