Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip handling #22

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Fix tooltip handling #22

merged 4 commits into from
Dec 2, 2022

Conversation

Obsouleet
Copy link
Contributor

@Obsouleet Obsouleet commented Nov 18, 2022

Gametooltip saw a lot changes in 10.0.2 - unfortunately this broke the addon.

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested my changes in-game.
    • In Retail WoW.
    • In Classic WoW.
    • In Wrath of the Lich King (Wrath/WotLK) Classic WoW.

Gametooltip saw a lot changes in 10.0.2 - unfortunately this broke the addon.
@Sharparam Sharparam self-assigned this Nov 19, 2022
@Sharparam Sharparam added the bug label Nov 19, 2022
Copy link
Member

@Sharparam Sharparam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! There are a few lint issues that need fixing, I've left a review comment on how to address it.

Are you able to test if these changes work in the Classic and WotLK clients as well? Otherwise I should be able to test it on Sunday evening.

KillTrack.lua Outdated Show resolved Hide resolved
Copy link
Member

@Sharparam Sharparam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the changes in Classic and Wrath Classic now and the new tooltip code does not exist there yet so there will need to be some code checking the WOW_PROJECT_ID and only use the new code on retail.

Do you feel comfortable adding those changes? I can also add them after the merge if that works better.

@toon1615
Copy link

toon1615 commented Dec 1, 2022

Hello. Any ETA on when this would get merged?

@Sharparam
Copy link
Member

There are the issued marked above that need fixing, but I might just adjust them myself for this PR later just to get it shipped out since it is important for fixing compatibility.

@Sharparam Sharparam merged commit 5874c2e into SharpWoW:master Dec 2, 2022
@Sharparam Sharparam changed the title Update KillTrack.lua Fix tooltip handling Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants