Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare_dataset gives unintuitive error if data directory missing #20

Closed
ressy opened this issue Aug 29, 2018 · 1 comment
Closed

prepare_dataset gives unintuitive error if data directory missing #20

ressy opened this issue Aug 29, 2018 · 1 comment
Milestone
Version 0.2.2

Comments

@ressy
Copy link
Member

ressy commented Aug 29, 2018

prepare_dataset should be updated to give a more intuitive error message if the data directory is missing at run time:

Error in locusmap[[locus]] : 
  attempt to select less than one element in get1index
@ressy ressy added this to the Version 0.2.2 milestone Dec 5, 2018
ressy added a commit that referenced this issue Dec 5, 2018
@ressy
add failing tests for load_dataset/prepare_dataset
3ba9f05 
Relates to #20
ressy added a commit that referenced this issue Dec 5, 2018
@ressy
Add error handling in load_dataset/prepare_dataset
5faa5f5 
Relates to #20
ressy added a commit that referenced this issue Dec 10, 2018
@ressy
Merge branch 'robust-input-checking' into dev
b4156f6 
Relates to #20 and #21
@ressy
Copy link
Member Author

ressy commented Dec 14, 2018

Fixed in 0.2.2.

@ressy ressy closed this as completed Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.2.2
Development

No branches or pull requests
1 participant
@ressy