Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tally_cts_per_locus fails if loci are missing in locus attributes table #21

Closed
ressy opened this issue Aug 29, 2018 · 1 comment
Closed

tally_cts_per_locus fails if loci are missing in locus attributes table #21

ressy opened this issue Aug 29, 2018 · 1 comment
Labels
bug
Milestone
Version 0.2.2

Comments

@ressy
Copy link
Member

ressy commented Aug 29, 2018

If the analyzed dataset includes locus names that are missing in the locus attributes table, tally_cts_per_locus fails with Error in tbl[i, as.character(cols.match[i])] : subscript out of bounds.
@ressy ressy added the bug label Aug 29, 2018
@ressy ressy added this to the Version 0.2.2 milestone Dec 5, 2018
ressy added a commit that referenced this issue Dec 5, 2018
@ressy
add failing test for wrong loci in analyze_dataset
38a309b 
This relates to #21.
ressy added a commit that referenced this issue Dec 5, 2018
@ressy
Check for locus name mismatch in analyze_dataset
6bf0862 
This relates to #21.
ressy added a commit that referenced this issue Dec 10, 2018
@ressy
Merge branch 'robust-input-checking' into dev
b4156f6 
Relates to #20 and #21
@ressy
Copy link
Member Author

ressy commented Dec 14, 2018

Fixed in 0.2.2.

@ressy ressy closed this as completed Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Version 0.2.2
Development

No branches or pull requests
1 participant
@ressy