Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing visibility declarations for XMLHeader making it actually usable #22

Closed
wants to merge 1 commit into from
Closed

Added missing visibility declarations for XMLHeader making it actually usable #22

wants to merge 1 commit into from

Conversation

regexident
Copy link

Doing …

let data = try encoder.encode(self, withRootKey: "catalog", header: XMLHeader(version: 1.0))

… fails outside of XMLParsing's project due to XMLHeader.init(version:) having internal visibility.

Added a bunch of other missing public/internal/fileprivate while I was at it.

@regexident regexident mentioned this pull request Oct 1, 2018
Open
@regexident regexident changed the title Added missing visibility declarations Added missing visibility declarations for XMLHeader making it actually usable Oct 1, 2018
@regexident regexident closed this Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@regexident