Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sheet_to_row_object_array throws away options object #80

Closed
ChrisBurkeBSD opened this issue Jul 7, 2014 · 1 comment
Closed

sheet_to_row_object_array throws away options object #80

ChrisBurkeBSD opened this issue Jul 7, 2014 · 1 comment

Comments

@ChrisBurkeBSD
Copy link

function sheet_to_row_object_array(sheet, opts) { return sheet_to_json(sheet, opts == null ? opts : {}); }

The opts object is never passed on here. I think replacing "opts == null ? opts : {}" with "opts || {}" would fit bette.

@SheetJSDev
Copy link
Contributor

@ChrisBurkeBSD I noticed that and actually fixed it in my local copy (both here and in js-xls ), so it will appear in the next update. Thanks for pointing it out!

I actually prefer opts != null ? opts : {} because the implicit boolean check is much more complex than a simple comparison against null or undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants