Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing templates - rajdip #915

Merged
merged 9 commits into from
May 21, 2024

Conversation

rajdip-b
Copy link
Contributor

No description provided.

@DonKoko DonKoko changed the title Signing templates Signing templates - rajdip Apr 17, 2024
@DonKoko
Copy link
Contributor

DonKoko commented Apr 17, 2024

hey @rajdip-b . I updated you branch and fixed all the conflicts. I added a bunch of @todos and answered your questions in the code. Still quite some stuff to updated but they are all basically the same. I tried to add @todo everywhere but it might be that I missed something. Here are the general points:

  • update all service functions to properly catch errors. See any service.server file for example
  • You are not using parseData to get form data
  • You are not using getParams to get params

@carlosvirreira
Copy link
Contributor

Excited for this release!

@DonKoko DonKoko merged commit 49e31a9 into Shelf-nu:signing-templates May 21, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants