Skip to content

Commit

Permalink
Fix local e2e script by copying the hermes' ruby files to the right f…
Browse files Browse the repository at this point in the history
…older (facebook#39580)

Summary:
Pull Request resolved: facebook#39580

While testing other features, I realized that the script to generate a project locally, starting from the template, has a bug for which we were using the outdated `hermes-engine.podspec` coming from the Hermes repo to build hermes.

This change fixes this by moving our files to the right folder.

## Changelog:
[Internal] - Fix local e2e test script copying hermes rubyscript over

Reviewed By: dmytrorykun

Differential Revision: D49497716

fbshipit-source-id: f1d582ec9d9c8007cbd2f9c876c061af12735f83
  • Loading branch information
cipolleschi authored and ShevO27 committed Sep 26, 2023
1 parent ecf568d commit 0c0635c
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions scripts/testing-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,14 @@ function buildArtifactsLocally(

// need to move the scripts inside the local hermes cloned folder
// cp sdks/hermes-engine/utils/*.sh <your_hermes_checkout>/utils/.
cp(
`${reactNativePackagePath}/sdks/hermes-engine/hermes-engine.podspec`,
`${reactNativePackagePath}/sdks/hermes/hermes-engine.podspec`,
);
cp(
`${reactNativePackagePath}/sdks/hermes-engine/hermes-utils.rb`,
`${reactNativePackagePath}/sdks/hermes/hermes-utils.rb`,
);
cp(
`${reactNativePackagePath}/sdks/hermes-engine/utils/*.sh`,
`${reactNativePackagePath}/sdks/hermes/utils/.`,
Expand Down

0 comments on commit 0c0635c

Please sign in to comment.